35 lines
1.4 KiB
Markdown
35 lines
1.4 KiB
Markdown
|
## Applicable to all contributors to this repository:
|
||
|
|
|
||
|
|
### All pull requests:
|
||
|
|
* [ ] Have you considered security (e.g., XSS)?
|
||
|
|
* [ ] Have you considered desktop, mobile, and tablet form-factors?
|
||
|
|
* [ ] Have you considered [accessibility best practices](https://www.w3.org/WAI/standards-guidelines/wcag/)?
|
||
|
|
|
||
|
|
### Code
|
||
|
|
* [ ] Are the commits squashed into one commit?
|
||
|
|
* [ ] Is the [branch name and commit message](CONTRIBUTING.md#conventions-for-branch-names-and-commit-messages) following team convention?
|
||
|
|
* [ ] Is the code linted?
|
||
|
|
* [ ] Are all open issues, questions, and concerns by reviewers answered, resolved, and reviewed?
|
||
|
|
|
||
|
|
### Quality assurance
|
||
|
|
* [ ] If applicable, are unit tests written and are they passing?
|
||
|
|
* [ ] If applicable, are integration tests written and are they passing?
|
||
|
|
* [ ] Have checks linked in your pull request passed?
|
||
|
|
|
||
|
|
### Documentation
|
||
|
|
* [ ] Are there meaningful code comments included?
|
||
|
|
|
||
|
|
## Applicable to community contributors:
|
||
|
|
* [ ] Have you granted SFRA team access to your fork? [Grant access](CONTRIBUTING.md#community-contributors)
|
||
|
|
|
||
|
|
## Applicable to SFRA team members:
|
||
|
|
|
||
|
|
### Documentation
|
||
|
|
* [ ] If applicable, is the change log updated?
|
||
|
|
* [ ] If applicable, have any UI text changes been reviewed by Documentation?
|
||
|
|
* [ ] If applicable, have any UI implementations been reviewed by the UX team?
|
||
|
|
|
||
|
|
### Security
|
||
|
|
* [ ] If applicable, has Security reviewed this code?
|
||
|
|
* [ ] If applicable, is a 3PP request submitted?
|