Scraper Update for testing

server/models/Note.js

@@ -4,6 +4,7 @@ let Note = module.exports = {}
 
 let Tags = require('@models/Tag')
 let Attachment = require('@models/Attachment')
+let Realtime = require('@helpers/Realtime')
 let ShareNote = require('@models/ShareNote')
 
 let ProcessText = require('@helpers/ProcessText')
@@ -12,7 +13,6 @@ const DiffMatchPatch = require('@helpers/DiffMatchPatch')
 
 const crypto = require('crypto')
 const cs = require('@helpers/CryptoString')
-const rp = require('request-promise');
 const fs = require('fs')
 const gm = require('gm')
 
@@ -513,12 +513,15 @@ Note.update = (userId, noteId, noteText, noteTitle, color, pinned, archived, has
 		})
 		.then((rows, fields) => {
 
-			if(typeof SocketIo != 'undefined'){
-				SocketIo.to(`user:${userId}`).emit('new_note_text_saved', {noteId, hash})
+			// The old `if(typeof SocketIo != 'undefined')` guard did not just
+			// skip the emit - it skipped the scrape too, so link scraping was
+			// silently disabled under Jest and could never be tested. Realtime
+			// no-ops safely without a socket server, so both now always run.
+			Realtime.emitToUser(userId, 'new_note_text_saved', {noteId, hash})
 
-				//Async attachment reindex
-				Attachment.scanTextForWebsites(SocketIo, userId, noteId, noteText)
-			}
+			//Async attachment reindex
+			Attachment.scanTextForWebsites(userId, noteId, noteText)
+				.catch(error => console.log('scanTextForWebsites failed', error.message))
 			
 			//Send back updated response
 			resolve(rows[0])